-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pad private key when passing it to the headless #1555
Pad private key when passing it to the headless #1555
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
CC'ing backend folks to review, here's the relevant stack trace.
For context: I think this error is caused because the launcher internally stores the private key without zero padding. The unpadded private key gets passed into the Should Libplanet allow unpadded private keys in their interface or not will be discussed in another issue of Libplanet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fixes some users' issues with private keys shorter than 32 bytes.